Cleanup `cpp/test/Slice/errorDetection` Testing
I was checking the C++ Code Coverage report, and to my surprise, parts of slice2java were being hit! Same for the other compilers.
After some searching, it turns out that the cpp/Slice/errorDetection test actually runs all the compilers.
We have this little bit slapped on the end of our test script in that folder:
current.write("Forward.ice... ")
for language in [
"cpp",
"cs",
"html",
"java",
"js",
"matlab",
"php",
"py",
"rb",
"swift",
]:
compiler = SliceTranslator("slice2%s" % language)
if not os.path.isfile(compiler.getCommandLine(current)):
continue
compiler.run(
current, args=["forward/Forward.ice", "--output-dir", "tmp"]
)
-
We should remove
htmlfrom this list.slice2htmlis long dead. We should also remove this logic where we just silently skip any compilers that don't exist. If something in this list is bogus, we should obviously see an error for it. -
We're only testing the compilers over
Forward.ice, a very small file:module test { class F; }. Either we should just completely remove this testing (because it is unexpected that acpptest is running the other compilers). Or we should at least expand this testing and run the compilers on a less useless Slice file.