ice icon indicating copy to clipboard operation
ice copied to clipboard

Use optional type for Reference compress

Open pepone opened this issue 1 year ago • 1 comments

          It would be cleaner to use a `bool?` here.

Originally posted by @bernardnormier in https://github.com/zeroc-ice/ice/pull/2366#discussion_r1657837589

pepone avatar Jun 27 '24 21:06 pepone

We should do the same in C++ with a std::optional<bool>. See:

https://github.com/zeroc-ice/ice/blob/69a59072e496c2e13d1cfe79baf779905f731e6e/cpp/src/Ice/Reference.h#L160 and https://github.com/zeroc-ice/ice/blob/69a59072e496c2e13d1cfe79baf779905f731e6e/cpp/src/Ice/Reference.h#L61

bernardnormier avatar Jun 28 '24 16:06 bernardnormier