ice icon indicating copy to clipboard operation
ice copied to clipboard

Back pressure fix from 3.7

Open bentoi opened this issue 1 year ago • 1 comments

This PR merges the back pressure fix from 3.7 to main.

bentoi avatar Jun 27 '24 13:06 bentoi

I don't understand how the idleTimeout tests works.

Since back pressure works as of this PR, and the idle check is currently back-pressure unaware, the first test should fail.

The test fails, fortunately:

Ice.ConnectionLostException: Exception of type 'Ice.ConnectionLostException' was thrown.
   at Ice.Internal.OutgoingAsyncBase.invokeException() in /Users/runner/work/ice/ice/csharp/src/Ice/Internal/OutgoingAsync.cs:line 95
--- End of stack trace from previous location ---
   at Ice.idleTimeout.AllTests.testIdleCheckDoesNotAbortConnectionWhenThreadPoolIsExhausted(TestIntfPrx p, TextWriter output) in /Users/runner/work/ice/ice/csharp/test/Ice/idleTimeout/AllTests.cs:line 41
   at Ice.idleTimeout.AllTests.allTests(TestHelper helper) in /Users/runner/work/ice/ice/csharp/test/Ice/idleTimeout/AllTests.cs:line 17
   at Ice.idleTimeout.Client.runAsync(String[] args) in /Users/runner/work/ice/ice/csharp/test/Ice/idleTimeout/Client.cs:line 12
   at Test.TestDriver.runTestAsync[T](String[] args) in /Users/runner/work/ice/ice/csharp/test/TestCommon/TestHelper.cs:line 232

test in Ice/idleTimeout failed:

Please comment it out for now.

bernardnormier avatar Jun 27 '24 16:06 bernardnormier

Fixed the CI failures:

  • server idle time bug
  • FD limit bug I've also disabled the failing idle timeout test.

bentoi avatar Jul 23 '24 05:07 bentoi