ice icon indicating copy to clipboard operation
ice copied to clipboard

Add deprecated as an alias for deprecate

Open bernardnormier opened this issue 1 year ago • 3 comments

Currently the metadata for a deprecated definition in Slice is "deprecate" and not the more common "deprecated".

I propose to keep "deprecate" but add "deprecated" as an alias. This way, you can use either and the result in the same.

bernardnormier avatar Apr 30 '24 19:04 bernardnormier

I'd be fine with adding this, although I'm not sure how much value it'll provide.

InsertCreativityHere avatar Apr 30 '24 19:04 InsertCreativityHere

So, we aren't even consistent ourselves. The metadata you use to mark something deprecated is deprecate But the string you pass in to ignore deprecation warnings is deprecated

Should we also let suppress-warning support deprecate?

InsertCreativityHere avatar May 01 '24 15:05 InsertCreativityHere

No, we should standardize on deprecated, not add more support for 'deprecate'.

bernardnormier avatar May 08 '24 19:05 bernardnormier

This was implemented in #2166.

InsertCreativityHere avatar May 20 '24 15:05 InsertCreativityHere