ice icon indicating copy to clipboard operation
ice copied to clipboard

Improve metadata validation

Open bernardnormier opened this issue 7 years ago • 1 comments

There is currently not enough metadata validation in the Slice compilers.

bernardnormier avatar Jun 21 '18 18:06 bernardnormier

While adding metadata validation to Slice to Swift compiler, noticed that Slice::Dictionary API doesn't allow to remove bogus metadata.

https://github.com/zeroc-ice/ice/blob/b0d4725aac41710d06078fc79f4a80d29209182c/cpp/src/Slice/Parser.h#L890-L891

This will be desirable to be able to sanitize the dictionary metadata like we do for other constructs.

I think we should come up with some kind of generic metadata validator that we can use everywhere, currently we are creating metadata visitors with each Slice compiler, but we don't have a consistent way to do the metada validation.

pepone avatar Oct 10 '19 22:10 pepone