ascii-art icon indicating copy to clipboard operation
ascii-art copied to clipboard

Added a feature of making the grey image into a coloured image.

Open NishantGadhe opened this issue 1 year ago • 5 comments

Added a function to make the grey text into a coloured one, one even colour throughout the text. Then continue on to make it a ascii art image. Wanted to add feature of different colours at different pixels according to our symbol but couldn't go that far, because I didn't knew how to do it. if you still find this useful add it to the branch. This is my first contribution. Thank you.

NishantGadhe avatar Oct 13 '23 10:10 NishantGadhe

🙏 Thanks for your pull request @NishantGadhe, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
141 32 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 44 193

I think this is a great idea. Thanks for your hard work.

I noticed you re-defined the convert_image_to_ascii function, but it's already defined (imported in the header of the file).

Instead, what I might recommend is adding another cli argument that takes in a color, then you can alter the final output (after the ascii conversion) depending on the system argument.

Thank you!

kennithnichol avatar Oct 16 '23 06:10 kennithnichol

⚠️ MERGE CONFLICT DETECTED!

@NishantGadhe A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

⚠️ MERGE CONFLICT DETECTED!

@NishantGadhe A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

⚠️ MERGE CONFLICT DETECTED!

@NishantGadhe A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.