ZtM-Job-Board icon indicating copy to clipboard operation
ZtM-Job-Board copied to clipboard

Published 20 hours ago • verified publisher icon zero-to-mastery

Arooj

Open arooj-12 opened this issue 10 months ago • 8 comments

arooj-12 avatar Apr 15 '24 12:04 arooj-12

🙏 Thanks for your pull request @arooj-12, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
3192 33 1
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 1059 2839

zero-to-mastery-bot[bot] avatar Apr 15 '24 12:04 zero-to-mastery-bot[bot]

Please only add one file with your name/submission @arooj-12

sophiabrandt avatar Apr 22 '24 15:04 sophiabrandt

🙏 Thanks for your pull request @arooj-12, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
3192 33 1
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 1060 2846

zero-to-mastery-bot[bot] avatar Apr 22 '24 15:04 zero-to-mastery-bot[bot]

@arooj-12 are you still interested in this PR?

sophiabrandt avatar May 05 '24 15:05 sophiabrandt

Yes I am. I have only pushed one file.

On Sun, 5 May 2024, 8:22 pm Sophia Brandt, @.***> wrote:

@arooj-12 https://github.com/arooj-12 are you still interested in this PR?

— Reply to this email directly, view it on GitHub https://github.com/zero-to-mastery/ZtM-Job-Board/pull/3192#issuecomment-2094849201, or unsubscribe https://github.com/notifications/unsubscribe-auth/A62XFIFOVHMBYC5VSAAR7MLZAZFB5AVCNFSM6AAAAABGHHFVHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA2DSMRQGE . You are receiving this because you were mentioned.Message ID: @.***>

arooj-12 avatar May 05 '24 18:05 arooj-12

@arooj-12 As you can see in the files tab on this page there are changes to 3 files. Please fix that, otherwise we cannot accept your pull request.

sophiabrandt avatar May 12 '24 06:05 sophiabrandt

Hi @arooj-12, I think you are getting confused with the requested changes, actually the reviewer is asking you to do the following changes:

  • UNDO the changes in the 0ifechukwu-daniel.json as the file belongs to someone else.
  • DELETE the other 1-arooj.json file as it doesn't match with your github username.

NOTES

  1. Only keep one file i.e. arooj-12.json .
  2. Don't add or remove or even change anything else other than arooj-12.json .

majidshakeelshawl avatar May 13 '24 07:05 majidshakeelshawl

@arooj-12 Hey, just letting you know that I'm going to close your PR in a few days. If you do not want to go through the work of making the requested changes, it might be easier to start fresh with a new pull request.

sophiabrandt avatar May 21 '24 14:05 sophiabrandt