ZtM-Job-Board icon indicating copy to clipboard operation
ZtM-Job-Board copied to clipboard

feature-test

Open cristinelpopescu opened this issue 2 years ago • 4 comments

Will be nice to add a photo profile in more shapes like square, round or rounded corners square

cristinelpopescu avatar Jul 06 '22 09:07 cristinelpopescu

Will be nice to add a photo profile in more shapes like square, round or rounded corners square

Hello @cristinelpopescu , thank you for opening an issue for adding a new feature. Currently the profile photo shape is rounded with the property;

.br-100 {
    border-radius: 100%;
}

Please provide clarification on the following areas;

  • Could you add a descriptive title for the feature you propose to be added. Currently you only have "feature-test" as the title.
for example;
Feature: Adding x to y component to change or improve z

Also, a few more questions to clarify;

  • Do you intend for this new feature to have square or rounded corners sqaure for every profile photo?
  • Should there be an option for each user to be able to select if they want rounded, square or rounded square corners if possible?
  • Could you describe the results of this change on the web application?

donmarvex avatar Jul 06 '22 11:07 donmarvex

Should be an option to let the user choose the shape he/she wants. For a square photo, we can fill it with the original shape. For rounded corners, a 5% radius can be a good look: .br-100 { border-radius: 5%; }

cristinelpopescu avatar Jul 07 '22 08:07 cristinelpopescu

Should be an option to let the user choose the shape he/she wants. For a square photo, we can fill it with the original shape. For rounded corners, a 5% radius can be a good look: .br-100 { border-radius: 5%; }

Alright @cristinelpopescu, I would want you to propose a design/implentation for this use case so we can run it over with other members and take steps to start working on it, if you want to be assigned to perform this task, it would also be lovely!

donmarvex avatar Jul 07 '22 09:07 donmarvex

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.

stale[bot] avatar Aug 11 '22 21:08 stale[bot]

This issue has been automatically closed because it has not had any recent activity. If your PR has a merge conflict, it must be resolved before it can be merged. Feel free to resolve and re-open Thank you for your contributions.

stale[bot] avatar Sep 24 '22 08:09 stale[bot]