ZtM-Job-Board
ZtM-Job-Board copied to clipboard
Changes to src/Assets/persons.json are still being committed
Description
Although, the src/Assets/persons.json
file is listed in the .gitignore
file, local changes made to the file by running npm start
are still being committed which results in thousands of additions/deletions which we cannot review immediately.
I believe that somewhere along the line during the lifespan of this project, these changes were being committed. Adding it to the .gitignore
file however doesn't stop these changes from being tracked.
Possible Resolutions?
- Require contributors to not commit these changes after running
npm start
by usinggit add Submissions/Submission file
. - Only require contributors to add their submission files and NOT run
npm start
locally. - If there's a way to ensure changes to the
../persons.json
file are not committed as it is included in.gitignore
. - Any other viable solution.
Effect
- Having this resolved will prevent maintainers from requesting contributors to rollback committed changes to the file.
- Avoid repetition of the step above across multiple contributions.
Please check this out @sophiabrandt @MattCSmith
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.