Animation-Nation icon indicating copy to clipboard operation
Animation-Nation copied to clipboard

adding my animation art

Open shay122990 opened this issue 10 months ago • 3 comments

shay122990 avatar Apr 22 '24 15:04 shay122990

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization! You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

⚠️ MERGE CONFLICT DETECTED!

@shay122990 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

⚠️ MERGE CONFLICT DETECTED!

@shay122990 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

⚠️ MERGE CONFLICT DETECTED!

@shay122990 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

⚠️ MERGE CONFLICT DETECTED!

@shay122990 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Aloha @shay122990 🙌 Thanks for your contribution and time ! Before we could merge your contribution, the following feedbacks need to be addressed first. Please address the given feedbacks

[!NOTE] Checked values - are the one that are correctly done

  • Please address all the unchecked elements
  • If you need guidance , please refer to the

[!TIP] If the name of your folder needs to be changed ensure to adjust the include.js

Feedbacks:

  • invalid folder name - name should be your github username ( shay122990 )

Note : include.js need to be reviewed after the folder change

For contributors: the include.js large modifications are most likely a format on save ( replacing all double quotes to single quotes )

🔹 Reference Acceptance criteria for a contribution

Correctly:

  • [ ] Folder name: named after the github user name in ./Art
    • [x] contains a HTML file: the contribution must have an HTML file
      • [x] has a tag to the CSS file of the project
      • [x] contains the HTML content for the animation
      • [x] does not contain a SVG replacing the whole HTML CSS animation requirements
      • [x] does not include any CSS library: No CSS library
      • [x] does not contain any JS script: No JS logic should be part of your submission
    • [x] contains a CSS file: the contribution must have a CSS file
    • [x] the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • [x] the pictural representation must not include the browser frame, just the animation
    • [ ] the contribution includes the correct contribution's details in include.js
      • [ ] the relative path should be correct : referring to the correct named folder
      • [x] author: the value should be the github name or github
      • [x] artName: the value should be the animation title
      • [ ] pageLink: the value should be the relative path to your project's HTML file
      • [ ] imageLink: should refer to the project relative path's image
      • [x] githubLink: the value should be your github profile link
      • [x] does not have chevrons
      • [x] does not have comments for each fields

LaurelineP avatar Aug 02 '24 09:08 LaurelineP

⚠️ MERGE CONFLICT DETECTED!

@shay122990 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.