davidr

[0r0ck3t]

[zero-to-mastery-bot[bot]]

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization! You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

[zero-to-mastery-bot[bot]]

🙏 Thanks for your pull request @0r0ck3t, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

• Student Resources
• ZTM Job Board
• Complete Web Developer Manual

---

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
2538	129	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
3	308	3366

[LaurelineP]

Aloha @0r0ck3t 🙌 Thanks for your contribution and time ! Before we could merge your contribution, the following feedbacks need to be addressed first. Please address the given feedbacks

[!NOTE] Checked values - are the one that are correctly done

• Please address all the unchecked elements
• If you need guidance , please refer to the

[!TIP] If the name of your folder needs to be changed ensure to adjust the include.js

Feedbacks:

• invalid folder name - name should be your github username
• review your include.js additions:
  • you are refering to other contributors links / path
  • you have typos
• missing the animation representation

🔹 Reference Acceptance criteria for a contribution

Correctly:

• [ ] Folder name: named after the github user name in ./Art
  • [x] contains a HTML file: the contribution must have an HTML file
    • [x] has a tag to the CSS file of the project
    • [x] contains the HTML content for the animation
    • [x] does not contain a SVG replacing the whole HTML CSS animation requirements
    • [x] does not include any CSS library: No CSS library
    • [x] does not contain any JS script: No JS logic should be part of your submission
  • [x] contains a CSS file: the contribution must have a CSS file
  • [x] the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
  • [x] the pictural representation must not include the browser frame, just the animation
  • [ ] the contribution includes the correct contribution's details in include.js
    • [ ] the relative path should be correct : referring to the correct named folder
    • [ ] author: the value should be the github name or github
    • [x] artName: the value should be the animation title
    • [ ] pageLink: the value should be the relative path to your project's HTML file
    • [ ] imageLink: should refer to the project relative path's image
    • [x] githubLink: the value should be your github profile link
    • [x] does not have chevrons
    • [x] does not have comments for each fields

[zero-to-mastery-bot[bot]]

⚠️ MERGE CONFLICT DETECTED!

@0r0ck3t A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

[zero-to-mastery-bot[bot]]

⚠️ MERGE CONFLICT DETECTED!

@0r0ck3t A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

[zero-to-mastery-bot[bot]]

⚠️ MERGE CONFLICT DETECTED!

@0r0ck3t A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.