Animation-Nation icon indicating copy to clipboard operation
Animation-Nation copied to clipboard

Adding my artsyness

Open Htanks opened this issue 10 months ago • 2 comments

Please add me to the list.

Htanks avatar Mar 27 '24 22:03 Htanks

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization! You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

🙏 Thanks for your pull request @Htanks, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2526 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 306 3362

🙏 Thanks for your pull request @Htanks, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2526 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 324 3422

🙏 Thanks for your pull request @Htanks, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2526 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 324 3422

🙏 Thanks for your pull request @Htanks, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2526 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 324 3422

🙏 Thanks for your pull request @Htanks, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2526 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 324 3422

Aloha @Htanks 🙌 Thanks for your contribution and time ! Before we could merge your contribution, the following feedbacks need to be addressed first. Please address the given feedbacks

[!NOTE] Checked values - are the one that are correctly done

  • Please address all the unchecked elements
  • If you need guidance , please refer to the

[!TIP] If the name of your folder needs to be changed ensure to adjust the include.js

Feedbacks

  • Missing folder named after your github username
  • HTML file misplaced --> should be within the folder mentioned above
  • No changes on include.js
  • Missing representation of your animation

🔹 Reference Acceptance criteria for a contribution

Correctly:

  • [ ] Folder name: named after the github user name in ./Art
    • [ ] contains a HTML file: the contribution must have an HTML file
      • [ ] has a tag to the CSS file of the project
      • [x] contains the HTML content for the animation
      • [x] does not contain a SVG replacing the whole HTML CSS animation requirements
    • [ ] contains a CSS file: the contribution must have a CSS file
    • [x] does not contain a JS file or JS logic : No JS logic should be part of your submission
    • [ ] the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • [ ] the pictural representation must not include the browser frame, just the animation
    • [ ] the contribution includes the correct contribution's details in include.js
      • [ ] the relative path should be correct : referring to the correct named folder
      • [ ] author: the value should be the github name or github
      • [ ] artName: the value should be the animation title
      • [ ] pageLink: the value should be the relative path to your project's HTML file
      • [ ] imageLink: should refer to the project relative path's image
      • [ ] githubLink: the value should be your github profile link
      • [ ] does not have chevrons
      • [ ] does not have comments for each fields

LaurelineP avatar Jul 31 '24 10:07 LaurelineP