Animation-Nation icon indicating copy to clipboard operation
Animation-Nation copied to clipboard

Published 20 hours ago • verified publisher icon zero-to-mastery

adding my 2 cents to the project

Open magic1986 opened this issue 1 year ago • 6 comments
trafficstars

Please add me to the list magic1986

magic1986 avatar Dec 12 '23 15:12 magic1986

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 293 3276

zero-to-mastery-bot[bot] avatar Dec 12 '23 15:12 zero-to-mastery-bot[bot]

Aloha 🙌 Thanks for your contribution and time ! Before we could merge your contribution, the following feedbacks need to be addressed first. Please address the given feedbacks

[!NOTE]

  • Please address all the unchecked element, the check one are the one correct and acknowledged for the contribution
  • If you need guidance , please refer to the

[!TIP] If the name of your folder needs to be changed ensure to adjust the include.js

Feedbacks

  • [ ] the name of your folder is incorrect / hence --> your folder relative path is incorrect: this should be your github username --> the name of your folder should be the name of your github user name
  • [ ] you added chevrons in the include.js around your user name: you should remove them
  • [ ] you should include a gif file of the animation as a preview and provide the link
  • [ ] in HTML
    • [ ] careful about your indentation
    • [ ] you have tags with no value within ( title )

🔹 Reference Acceptance criteria for a contribution

  • [ ] Folder name: named after the github user name in ./Art
    • [x] contains a HTML file: the contribution must have an HTML file
      • [x] has a tag to the CSS file of the project
      • [x] contains the HTML content for the animation
      • [x] does not contain a SVG replacing the whole HTML CSS animation requirements
    • [x] contains a CSS file: the contribution must have a CSS file
    • [x] does not contain a JS file or JS logic : No JS logic should be part of your submission
    • [ ] the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • [ ] the pictural representation must not include the browser frame, just the animation
    • [x] the contribution includes the correct contribution's details in include.js
      • [ ] the relative path should be correct : refering to the correct named folder
      • [x] author: the value should be the github name or github
      • [ ] artName: the value should be the animation title
      • [ ] pageLink: the value should be the relative path to your project's HTML file
      • [ ] imageLink: should refer to the project relative path's image
      • [ ] githubLink: the value should be your github profile link

LaurelineP avatar Jul 02 '24 16:07 LaurelineP

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 319 3409

zero-to-mastery-bot[bot] avatar Jul 02 '24 16:07 zero-to-mastery-bot[bot]

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 319 3409

zero-to-mastery-bot[bot] avatar Jul 02 '24 16:07 zero-to-mastery-bot[bot]

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 319 3409

zero-to-mastery-bot[bot] avatar Jul 02 '24 16:07 zero-to-mastery-bot[bot]

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 319 3409

zero-to-mastery-bot[bot] avatar Jul 02 '24 16:07 zero-to-mastery-bot[bot]

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 324 3422

zero-to-mastery-bot[bot] avatar Aug 01 '24 09:08 zero-to-mastery-bot[bot]

🙏 Thanks for your pull request @magic1986, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2449 156 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 324 3422

zero-to-mastery-bot[bot] avatar Aug 01 '24 09:08 zero-to-mastery-bot[bot]