Ivan Kurnosov

Results 180 comments of Ivan Kurnosov

Indeed, I could reproduce it on the psalm.dev: https://psalm.dev/r/7f0799fc21

As a temporary solution - I use https://web.telegram.org/a/ it works 🤷 (see that it's `/a/` not `/k/`).

> But why return nullable FormInterface Because `createForm`'s second argument `$data` is declared as having `= null` by default in symfony, and having generic parameter nullable was the _only_ way...

@M393 oh wow, didn't know that. In that case it possibly would be a room to improve the error message?

> Related exception lines in code: Yep, I already debugged through it :-) It was also to confirm whether the corresponding change would be accepted/welcomed overall.

UPD: I didn't abandon it, a little busy at work, will return when have a little spare time (unless someone wants to join and help me untangle it :-) )

@Madrigal you have simply chosen a CVE that affects a package that has a version that does not need percent encoding. Here is a raw response from a `aws` cli...

> So the change is only a "security feature" @heiglandreas I didn't try to sell my PR as a "security feature" - it was fixing a real _typical_ use case...

Okay, I have the third suggestion then: Symfony stop throwing the `CookieTheftExceptions` exception: it's useless, and cannot really be handled. Instead - it emits an event and if you care...

Okay, I have refreshed my memories about the original problems with the code, and current state. And also gave it a weekend of thinking. So, more weighted responses: > Currently...