zeripath

Results 158 comments of zeripath

Yup I need trace logs for this. You should be able to set the `EXPRESSION=modules/graceful` if you don't want to be overwhelmed.

The trace logs are missing the important things I need. I don't see `Awaiting server start-up` but yet the goroutine stack definitely implies that should have happened... --- Now looking...

``` goroutine 15 [select]: code.gitea.io/gitea/modules/graceful.(*Manager).awaitServer(0xc0013df560, 0x0) /source/modules/graceful/manager_windows.go:244 +0x1d8 code.gitea.io/gitea/modules/graceful.(*Manager).Execute(0xc0013df560, {0x4227fc0?, 0xae6285?, 0xc0012adfd0?}, 0xc001304240, 0xc0012b6780?) /source/modules/graceful/manager_windows.go:124 +0xe7 golang.org/x/sys/windows/svc.serviceMain.func2() /go/pkg/mod/golang.org/x/[email protected]/windows/svc/service.go:232 +0x45 created by golang.org/x/sys/windows/svc.serviceMain /go/pkg/mod/golang.org/x/[email protected]/windows/svc/service.go:231 +0x2b4 ``` Still seeing awaitServer... So may...

Is it possible that you don't have INSTALL_LOCK set? If not, well there's your problem. The server won't be ready until that lock is set.

Thanks. The whole SVC thing is a red herring. The problem is: https://github.com/go-gitea/gitea/blob/3d52edc7a43ca429b7921b96c3663c32179881ab/modules/ssh/init.go#L19-L22 This block needs to call `builtinUnused()`

Workaround for the moment is to enable ssh - you don't need to enable to internal ssh server and you can even set the SSH_DOMAIN to something like `NOT AVAILABLE...

You might want to take a look at the way I've done it in the main Gitea binary. I'm not certain that the technique used there is definitely applicable but...

Fair enough. I'm not particularly au fait with how tea does things but saw what you were doing looked slightly similar.

Whilst a string.Builder can reduce allocations it may actually be better to keep a small buffer or the builder around in order to reduce allocs further.

I think this should be fixed following the merging of #329