Web3Swift icon indicating copy to clipboard operation
Web3Swift copied to clipboard

Swiftlint rule to enforce final classes

Open driver733 opened this issue 7 years ago • 3 comments

As per #41 Every class must be final. We should create a new rule for that.

driver733 avatar Mar 02 '18 20:03 driver733

@biboran/z please, pay attention to this issue

0crat avatar Mar 02 '18 20:03 0crat

@biboran see https://github.com/realm/SwiftLint/issues/228

driver733 avatar Mar 02 '18 21:03 driver733

@driver733 I think our rule is a lot simpler. We simply need every class to be final.

I believe the request in the issue realm/SwiftLint#228 is a bit ridiculous. What's the point of enforcing final (except maybe for dispatch) if the rule can be overridden by subclassing?

abdulowork avatar Mar 03 '18 10:03 abdulowork