Web3Swift
Web3Swift copied to clipboard
zeriontech
Missing linter rules for prohibiting object naming ending with ER
We should have a linter rule to prevent creating objects that end with ER. This will encourage contributors to think OODD.
The job #45 assigned to @biboran/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.
Manual assignment of issues is discouraged, see §19: -5 points just awarded to @biboran/z, total is +120
It is strongly discouraged to assign jobs to their creators, see §19: -15 points just awarded to @biboran/z, total is +120
So after some poking around it seems like it would be easier to specify prohibited "er" words rather than prohibit all "er" words and to specify exceptions.
I think it would be a better idea to develop a dictionary of prohibited terms.
@biboran I believe that we should create a custom SwiftLint rule for that. (-ER, not that dictionary solution)
@driver733 I already tried and what comes up is there are too many words that end with ER and OR that are not problematic. For example Parameter.
Even qulice doesn't have such a rule as far as I know: https://github.com/teamed/qulice/issues/109
I see blacklist as the only solution
@biboran/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.
@biboran/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.
@driver733 I think we should still come up with a blacklist for class names (and maybe parameter names). It can free up a lot of the reviews time.