openstreetmap-license-change
openstreetmap-license-change copied to clipboard
zerebubuth
Delete test for tags?
We were discussing the redaction on the Danish mailing list (mostly in terms of getting the few remaining issues in Denmark fixed before the bot starts running :), and we had a question whether deleting a troublesome tag and then adding it again would make it survive.
There are a bunch of those from decliners who have named streets and the like without touching the geometry.
I couldn't find it in the tag tests, so I tried coding it myself. I'll attach a patch. The answer seems to be yes as expected (if my first-time Ruby is correct).
Oops, no attachment on github. Oh, well, here we go: https://gist.github.com/2990667
The comment and the code are differing. The bot is currently deleting the tag and your test case passes, but your comment say that we should keep the tag.
And for the mailing list you can use odbl=clean on the objects.
(Something went wrong when I pasted the code into the gist so a couple of lines were cut off, I've fixed that now)
Aha, I thought the last Redact[OSM::Node, 1, 4, :visible] meant that the tag would be visible? If not, is this not a bug in the bot? Perhaps it's not important.
I've rewritten the comment for the test to be slightly clearer. Sorry for the spam.