zscilib

zscilib copied to clipboard

I'm not sure I'm understanding this block of code, but there's definitely an unchecked out-of-bounds write here which is crashing my code: ``` int zsl_mtx_eigenvectors(struct zsl_mtx *m, struct zsl_mtx *mev,...

0xabe1

When multiplying 3 matrices of sizes 1x5, 5x5 and 5x1 respectively using the zsl_mtx_mult() function this is the answer: 1.000002000003723766352603519181e-02 When multiplying these matrices using the zephyr RTOS by writing...

Ananyaaynana

https://github.com/zephyrproject-rtos/zscilib/blob/34c3432e81085bb717e4871d21ca419ae0058ec5/src/matrices.c#L1785-L1791 In the if statement on line 1788, ```x > -epsilon``` always evaluates to true when x is 0 because epsilon is equal to 1e-6 and 0 is always bigger...

stonemaguire

Fixes some logical issues in matrix and vector code

1

Address some small logical and code problems identified in the issues below: Fixes #46 Fixes #47 Fixes #48

microbuilder

https://github.com/zephyrproject-rtos/zscilib/blob/0035be5e6a45e4ab89755b176d305d7a877fc79c/src/vectors.c#L487 The if statement will return always true if (x>=1E-5 || xdata[j] >= 1E-5 || v->data[j] data[j] is not smaller then the epsilon range.

ruehlchris

https://github.com/zephyrproject-rtos/zscilib/blob/0035be5e6a45e4ab89755b176d305d7a877fc79c/src/matrices.c#L316 Looks like incomplete code in function zsl_mtx_binary_op(). Missing 'break;' in switch statement start at ZSL_MTX_BINARY_OP_MEAN: Please correct.

ruehlchris

https://github.com/zephyrproject-rtos/zscilib/blob/0035be5e6a45e4ab89755b176d305d7a877fc79c/src/vectors.c#L375 the logic check for the right hand side never match because it check for x epsilon. correction x (-) epsilon. ` if ((v->data[g - x] >= 0.0 && v->data[g...

ruehlchris

This MR adds the module name in zephyr/module.yml, as is stated in the [official documentation](https://docs.zephyrproject.org/latest/develop/modules.html#module-name): > Each Zephyr module is given a name by which it can be referred to...

Jappie3