zephyr
zephyr copied to clipboard
Add realtek rts5912 soc
This PR adds support for the RTS5912 EC Chip from Realtek.
The initial support for the board includes TIMER, GPIO, CLOCK_CONTROL, PINCTRL.
please help us review the pull request.
Thanks!
Hello @JasonLin-RealTek, and thank you very much for your first pull request to the Zephyr project! Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary. If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
please, organize commit content properly, it seems that first commit contains e.g. pinctrl stuff which should not be there.
We followed the suggestions to fix the code and passed the twister testing. Are there any further suggestions? Could you please approve the PR?
I can't see any changes regarding my previous request
We misunderstood the request and moved the [pinctrl+register] files to their own commit. Now we have committed the device tree file into a single commit. Is that correct?
@gmarull @nordicjm pinging. Can you please review the changes if they make this pull request better.
Please, avoid combo commits like d20f604. DT bits need to be added progressively as support for its nodes is added.
Thanks for your advise. We have moved those DT bits to their own commits.
Needs rebase
About z_arm_on_enter_cpu_idle, RTS5912 will keep this method to not let cpu enter idle.
There's few compliance warnings as well, you can run that check locally with something like ./scripts/ci/check_compliance.py -c origin/main..HEAD if it helps (adjust the range as necessary
We add the realtek into MAINTAINERS.yml in latest commit https://github.com/zephyrproject-rtos/zephyr/pull/75267#discussion_r1777281955
We have run ruff to format the img_gen.py.
Fix merging conflicts.
@gmarull could you take a look?
Hi @JasonLin-RealTek! Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁