zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

boards: sipeed: longan_nano: update SPI documentation

Open maxinbjohn opened this issue 1 year ago • 3 comments

Update SPI documentation for longan_nano. In longan_nano board, spi1 is connected to sdhc0. Verified the functionality using "samples/subsys/fs/fs_sample".

Fixes: #64759

maxinbjohn avatar Apr 28 '24 06:04 maxinbjohn

Shouldn't you also mention that the SPI1 is connected to SDMC?

Sure, will include it in the documentation. Thanks.

maxinbjohn avatar May 06 '24 08:05 maxinbjohn

Shouldn't you also mention that the SPI1 is connected to SDMC?

Sure, will include it in the documentation. Thanks.

Are you planning to update this PR which this addition?

MaureenHelm avatar May 22 '24 18:05 MaureenHelm

Shouldn't you also mention that the SPI1 is connected to SDMC?

Sure, will include it in the documentation. Thanks.

Are you planning to update this PR which this addition?

Sorry that it was left unattended. Updated now.

maxinbjohn avatar May 23 '24 08:05 maxinbjohn

Gentle ping ... Some of the CI acceptance tests failed here due to the known "No module named 'serial'" error. It was fixed in this commit:

commit 8c8e2f6243f147953ce3fadb999c4e2a5faf4f5e Author: Stephanos Ioannidis [email protected] Date: Thu May 23 22:08:03 2024 +0900

doc: requirements: Add pyserial

Since 7eaca455faf6ff8d9a92c4392da281dab08d0c2b, pyserial is required for
building docs because `DeviceAdapter` from the `pytest-twister-harness`
plugin, which is imported by autodoc, now depends on it.

Signed-off-by: Stephanos Ioannidis <[email protected]>

maxinbjohn avatar Jun 07 '24 10:06 maxinbjohn

Gentle ping ... Some of the CI acceptance tests failed here due to the known "No module named 'serial'" error. It was fixed in this commit

please just rebase and force push, this will do the trick :)

kartben avatar Jun 07 '24 10:06 kartben