zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

sensors: lps22hb: Enhance driver with trigger

Open stubb0rnCoder opened this issue 1 year ago • 1 comments

Using the LPS22HH driver as a basis, this PR replaces the very limited existing driver for the HB variant with a more sophisticated one that allows setting a trigger and gives a basis for further improvements.

stubb0rnCoder avatar Feb 18 '24 15:02 stubb0rnCoder

Hello @stubb0rnCoder, and thank you very much for your first pull request to the Zephyr project! Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary. If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions[bot] avatar Feb 18 '24 15:02 github-actions[bot]

Also split the work into atomic commits

Would you like me to split the already commited work or for future work?

PS. This is my first PR to Zephyr and I struggled a bit with signing-off so I ended up with a single commit to fix commits accidently not singed off

stubb0rnCoder avatar Apr 07 '24 08:04 stubb0rnCoder

Also split the work into atomic commits

Would you like me to split the already commited work or for future work?

PS. This is my first PR to Zephyr and I struggled a bit with signing-off so I ended up with a single commit to fix commits accidently not singed off

I think you need to rebase. Then what I was asking was to arrange the work into a proper commit flow. If the only thing you did was to change lps22hb into a modern form (like lps22hh), then I guess a single commit is enough. And remember to provide a proper commit message as well.

avisconti avatar Apr 10 '24 15:04 avisconti

Also, if you do make it so that existing code does not need updating, I'd split this into two PRs: One PR for the driver code, which will still work with the existing boards and samples, and a PR updating the boards and samples to the new name.

Multiple smaller PRs are easier to review.

glenn-andrews avatar Apr 11 '24 13:04 glenn-andrews

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Jun 14 '24 00:06 github-actions[bot]

@stubb0rnCoder If you're still around I'd love to work with you on landing this.

glenn-andrews avatar Jun 29 '24 00:06 glenn-andrews