zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

mgmt/osdp: cp: disallow unexpected SC responses

Open sidcha opened this issue 1 year ago • 6 comments

When CP has a secure channel active, it should never receive a REPLY_CCRYPT or REPLY_RMAC_I. Since these responses change the SC state, let's also make sure that they are accepted only when they are expected: in response to commands CMD_CHLNG and CMD_SCRYPT respectively.

sidcha avatar Nov 01 '23 23:11 sidcha

cc: @jakub-uC

sidcha avatar Nov 03 '23 09:11 sidcha

@carlescufi Can you please take a look at this PR, thanks.

sidcha avatar Nov 24 '23 10:11 sidcha

This PR is bit rotting :) Can anyone please take a look.

cc: @carlescufi @jakub-uC

sidcha avatar Dec 05 '23 18:12 sidcha

@jakub-uC Ping

r2r0 avatar Dec 18 '23 07:12 r2r0

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Feb 17 '24 00:02 github-actions[bot]

Ping.

sidcha avatar Feb 17 '24 07:02 sidcha

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Apr 18 '24 00:04 github-actions[bot]

@sidcha can you please rebase to trigger previously stuck CI jobs?

kartben avatar Jun 07 '24 10:06 kartben

@sidcha thanks for your patience - should be merged anytime now!

kartben avatar Jun 07 '24 13:06 kartben