zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

boards: add hpmicro hpm6750evkmini board

Open Cherish-Gww opened this issue 1 year ago • 14 comments

This is an risc-v board. we also add hpmicro SoC support, as well as gpio, pinctrl, uart driver.

Cherish-Gww avatar Oct 19 '23 09:10 Cherish-Gww

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_hpmicro N/A https://github.com/zephyrproject-rtos/hal_hpmicro/pull/3 zephyrproject-rtos/hal_hpmicro#3/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

zephyrbot avatar Oct 19 '23 09:10 zephyrbot

this PR needs to be split into meaningful commits.

split done, I have tested zephyr/samples/hello_world/ on my platform, it runs ok.

Cherish-Gww avatar Oct 20 '23 10:10 Cherish-Gww

@fkokosinski @gmarull If you have time, please help me review this patch. Thank you very much.

Cherish-Gww avatar Oct 30 '23 02:10 Cherish-Gww

@fkokosinski sorry, I resolved a conflict that dismissed your approve Will sorting alphabetically in CMakeLists.txt reduce the occurrence of conflicts?

Cherish-Gww avatar Nov 10 '23 02:11 Cherish-Gww

@gmarull Do you have time to review the patch? I'm looking forward to it every day.

Cherish-Gww avatar Nov 10 '23 02:11 Cherish-Gww

@MaureenHelm Could you help me review this PR?

Cherish-Gww avatar Nov 15 '23 02:11 Cherish-Gww

you're adding a board before it can be built, please, make sure stuff is bisectable

I don't quite understand this sentence, what should I do for this PR?

Cherish-Gww avatar Nov 17 '23 10:11 Cherish-Gww

you're adding a board before it can be built, please, make sure stuff is bisectable

I don't quite understand this sentence, what should I do for this PR?

Hi! The problem is that if you check out on this commit 569fed81d171ed22d300da4d0941fe1a57878f3e you can't build the board it adds. This potentially may give you a false-negative when bisecting.

You should reorder your commits so that their dependencies are added earlier, e.g. SoC is added before the board.

fkokosinski avatar Nov 17 '23 13:11 fkokosinski

you're adding a board before it can be built, please, make sure stuff is bisectable

I don't quite understand this sentence, what should I do for this PR?

Hi! The problem is that if you check out on this commit 569fed8 you can't build the board it adds. This potentially may give you a false-negative when bisecting.

You should reorder your commits so that their dependencies are added earlier, e.g. SoC is added before the board.

@fkokosinski @gmarull https://github.com/zephyrproject-rtos/zephyr/pull/64117/commits is that ok?

Cherish-Gww avatar Nov 21 '23 05:11 Cherish-Gww

@gmarull https://github.com/zephyrproject-rtos/zephyr/pull/64117/commits is that ok?

Cherish-Gww avatar Dec 04 '23 05:12 Cherish-Gww

@gmarull Do you have time to help me take a look?

Cherish-Gww avatar Dec 11 '23 03:12 Cherish-Gww

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

Cherish-Gww avatar Dec 21 '23 02:12 Cherish-Gww

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

Hi! Ideally, you'd need to get ACKs from maintainers of the areas that you're modifying here, e.g. gpio, serial etc. You also can ask for help on the #pr-help channel on Discord.

fkokosinski avatar Jan 10 '24 08:01 fkokosinski

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

Hi! Ideally, you'd need to get ACKs from maintainers of the areas that you're modifying here, e.g. gpio, serial etc. You also can ask for help on the #pr-help channel on Discord.

Oh Thanks you very much, I will continue to modify this PR.

Cherish-Gww avatar Jan 10 '24 08:01 Cherish-Gww

Needs to be migrated to hwmv2

OK, I will understand hwmv2 and modify my PR as soon as possible.

Cherish-Gww avatar Feb 26 '24 08:02 Cherish-Gww

Needs to be migrated to hwmv2

Should I submit my PR to the collab-hwm branch? and change to hwmv2?

Cherish-Gww avatar Feb 27 '24 03:02 Cherish-Gww

Needs to be migrated to hwmv2

Should I submit my PR to the collab-hwm branch? and change to hwmv2?

Can use what is on hwmv2 as a starting point to see how to transition but we will not be merging new boards/socs into that branch

nordicjm avatar Feb 27 '24 06:02 nordicjm

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Apr 28 '24 00:04 github-actions[bot]