zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

boards: arm: stm32f3_seco_d23: Add SECO JUNO SBC-D23 board

Open ektor5 opened this issue 2 years ago • 4 comments

Add support for SECO JUNO board embedded microcontroller STM32F302VC, designed to extend capabilities of the main processor Rockchip PX30. The microcontroller provides several interfaces, such as 2 and 4-Wire UARTs, USB, CAN, Modbus, 8-channels Timer, SPI, I2C and GPI/Os. The communication between the two processors is realized with an internal SPI line.

Based on stm32f3_disco board.

Signed-off-by: Ettore Chimenti [email protected]

ektor5 avatar Sep 09 '22 11:09 ektor5

@ektor5 we don't use fixup patches in Zephyr PRs, patch series that represent the development history or aid reviewability are good, but review fixup should get amended to the original patches. In this case you probably want to squash the whole PR down into a single patch and force push it. Can you do that? The full development workflow documentation is: https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

fabiobaltieri avatar Sep 13 '22 16:09 fabiobaltieri

@fabiobaltieri no problem, I thought it could be done from Github once approved.

ektor5 avatar Sep 13 '22 16:09 ektor5

@fabiobaltieri no problem, I thought it could be done from Github once approved.

It could in this case since this would be a single patch PR, but in general we want to preserve the (amended) development history.

fabiobaltieri avatar Sep 13 '22 16:09 fabiobaltieri

@fabiobaltieri Got it, thanks for the heads up. :+1:

ektor5 avatar Sep 13 '22 16:09 ektor5

/__w/zephyr/zephyr/drivers/counter/counter_ll_stm32_rtc.c:453:2: error: #warning Kconfig COUNTER_RTC_STM32_CLOCK_LS* are deprecated. Please define clock source in dtsi file [-Werror=cpp]
  453 | #warning Kconfig COUNTER_RTC_STM32_CLOCK_LS* are deprecated. Please define clock source in dtsi file
      |  ^~~~~~~

From the CI, the STM32 RTC clock config has been updated since the last snapshot, see #50104 for the changes.

fabiobaltieri avatar Nov 18 '22 12:11 fabiobaltieri

RTC Clock fixed. Thanks @fabiobaltieri

ektor5 avatar Nov 19 '22 09:11 ektor5

https://github.com/zephyrproject-rtos/zephyr/pull/52342 should be reviewed and merged first

erwango avatar Nov 28 '22 08:11 erwango

Heya, we don't use merge commits in Zephyr, sorry I know the UI is confusing, unfortunately we can't disable the "update branch" button. Can you force push without the merge commit in the commit stack?

fabiobaltieri avatar Nov 28 '22 11:11 fabiobaltieri

@fabiobaltieri I'm really sorry, I wanted to do the rebase, I didn't realise it was going to merge instead. Will rebase manually and repush.

ektor5 avatar Nov 28 '22 13:11 ektor5

@fabiobaltieri I'm really sorry, I wanted to do the rebase, I didn't realise it was going to merge instead. Will rebase manually and repush.

Not a problem, the UI is confusing but we have no control over it, there's few feature requests already about this specific one but they seem to be stale, I'll look into adding a gitlint check about it.

fabiobaltieri avatar Nov 28 '22 13:11 fabiobaltieri

(https://github.com/zephyrproject-rtos/zephyr/pull/52342 merged, rebased this so the first commit get skipped from this pr)

fabiobaltieri avatar Nov 29 '22 09:11 fabiobaltieri

@erwango ping

gmarull avatar Dec 19 '22 08:12 gmarull