zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

mbedtls: add CONFIG_MBEDTLS_HEAP_SELF_INIT

Open daldridge-quic opened this issue 3 years ago • 1 comments

Add a config flag to enable conditional mbedtls heap initialization at startup, defaulting to enabled.

Also make the mbedtls_init() non-static so it can be called externally.

Signed-off-by: Eugene Cohen [email protected] Signed-off-by: Dave Aldridge [email protected]

daldridge-quic avatar Jul 12 '22 13:07 daldridge-quic

@ceolin @d3zd3z @nashif @andyross is there anything i can do to help out with the review ?

daldridge-quic avatar Jul 27 '22 10:07 daldridge-quic

um, didn't realise requesting a review would blow away existing requests, sorry about that @d3zd3z @nashif @andyross @tbursztyka @stephanosio

daldridge-quic avatar Sep 02 '22 09:09 daldridge-quic

@tejlmand I have addressed your feedback, if you could take a look that would be great.

daldridge-quic avatar Sep 22 '22 09:09 daldridge-quic

@tejlmand @d3zd3z I believe I have addressed all feedback in the pull request. @andyross @dcpleung any chance of a review

daldridge-quic avatar Oct 06 '22 11:10 daldridge-quic

@mniestroj @dcpleung thanks for the approvals. @tejlmand i believe i have addressed all of your requested changes, could you please re-review. @andyross any chance of a review please.

daldridge-quic avatar Nov 29 '22 10:11 daldridge-quic

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Jan 29 '23 00:01 github-actions[bot]

@d3zd3z As far as I can tell I have actioned all requested changes and I'm just waiting for review/approval. Can you please help here ?

daldridge-quic avatar Jan 30 '23 11:01 daldridge-quic

@tejlmand FYI, your change request is still pending. @daldridge-quic We are currently in a feature merge freeze for the upcoming 3.3 release. Unless you can justify this as fixing a bug, this will need to wait until 3.3 is released.

stephanosio avatar Jan 30 '23 13:01 stephanosio

@stephanosio No rush on this as it is not a bug fix. Assuming everyone is happy it can wait until after the v3.3 release. Thanks for your help.

daldridge-quic avatar Jan 30 '23 13:01 daldridge-quic

@stephanosio @tejlmand Now the v3.3.0 release has been made can this PR be addressed please.

daldridge-quic avatar Feb 23 '23 13:02 daldridge-quic

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Apr 25 '23 00:04 github-actions[bot]

@d3zd3z As far as I can tell I have actioned all requested changes and I'm just waiting for review/approval. Can you please help here ?

daldridge-quic avatar Apr 25 '23 08:04 daldridge-quic

@stephanosio Hiya, you removed the Stale label from this MR last time it was applied, are you able to help again please ?

daldridge-quic avatar Apr 25 '23 08:04 daldridge-quic

@d3zd3z can you take another look?

fabiobaltieri avatar Jun 20 '23 10:06 fabiobaltieri

Many thanks to everyone involved with getting this PR merged.

daldridge-quic avatar Jul 14 '23 08:07 daldridge-quic