zephyr
zephyr copied to clipboard
fix: boards: sam0: uart: remove collision_detect parsing
Removing collision detect property from devicetree parsing, no collision_detect parameter included in device tree for any platform
Hi @arvinf ,
Would like you comment about this change ?
Original PR: #34715
Hi @sm3vhf ,
May you apply correct fix so we can move this forward?
@nandojve sure, i'll try!! I'm quite new to the process though, so not sure everything with the pull request will be correct all the way, but i'll try ;)
Hi @sm3vhf ,
@nandojve sure, i'll try!! I'm quite new to the process though, so not sure everything with the pull request will be correct all the way, but i'll try ;)
No problem, you should use correct property which is defined here: https://github.com/zephyrproject-rtos/zephyr/blob/da041942c286c985d34543b676e560c1e2a6c77a/dts/bindings/serial/atmel%2Csam0-uart.yaml#L32
Please, update DT_INST_PROP
to DT_INST_PROP_OR
with default value of 0 (false)
-.collision_detect = DT_INST_PROP(n, collision_detect), \
+.collision_detect = DT_INST_PROP_OR(n, collision_detection, 0), \
Codecov Report
Merging #45922 (da04194) into main (e9d3791) will increase coverage by
0.16%
. The diff coverage is0.00%
.
:exclamation: Current head da04194 differs from pull request most recent head 36f00cf. Consider uploading reports for the commit 36f00cf to get more accurate results
@@ Coverage Diff @@
## main #45922 +/- ##
==========================================
+ Coverage 49.99% 50.16% +0.16%
==========================================
Files 648 663 +15
Lines 81232 82991 +1759
Branches 19080 19514 +434
==========================================
+ Hits 40615 41631 +1016
- Misses 33883 34464 +581
- Partials 6734 6896 +162
Impacted Files | Coverage Δ | |
---|---|---|
arch/posix/core/irq.c | 86.66% <ø> (ø) |
|
arch/posix/core/posix_core.c | 100.00% <ø> (ø) |
|
arch/posix/core/swap.c | 100.00% <ø> (ø) |
|
arch/posix/include/posix_arch_internal.h | 100.00% <ø> (ø) |
|
arch/x86/core/acpi.c | 41.53% <0.00%> (ø) |
|
arch/x86/core/early_serial.c | 70.83% <ø> (ø) |
|
arch/x86/core/ia32/irq_manage.c | 82.50% <ø> (ø) |
|
arch/x86/core/x86_mmu.c | 81.95% <0.00%> (+0.44%) |
:arrow_up: |
subsys/logging/log_msg.c | 62.96% <0.00%> (-26.24%) |
:arrow_down: |
.../debug/coredump/coredump_backend_flash_partition.c | 42.70% <0.00%> (-16.08%) |
:arrow_down: |
... and 231 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e9d3791...36f00cf. Read the comment docs.
What is causing the failing tests? Do I need to make any more changes for those??
@nandojve Thank you for the help!! Is there something I am missing to do? Is the merge expected to merge automatically, or is there something more left for me to do??