zephyrproject-rtos
Zephyr usbc subsystem
These pull requests are part of a larger effort to port the Google ChromeOS USB-C Stack to Zephyr. See issue https://github.com/zephyrproject-rtos/zephyr/issues/38371.
Currently the State Machine Framework https://github.com/zephyrproject-rtos/zephyr/pull/38088 and Type-C Port Controller Driver https://github.com/zephyrproject-rtos/zephyr/pull/41856 has merged. This PR implements the USBC-C Subsystem from which Type-C / Power delivery application can be created. Once this PR merges, Power Delivery Sink only applications can be created.
The following west manifest projects have been modified in this Pull Request:
| Name | Old Revision | New Revision | Diff |
|---|---|---|---|
| hal_stm32 | https://github.com/zephyrproject-rtos/hal_stm32/commit/51b373cd3455b8c2b9babbf6ff41918116a442ac | https://github.com/zephyrproject-rtos/hal_stm32/commit/c87358a3e9b99e0f8f18816f1a74777fe80d1ab6 (main) | zephyrproject-rtos/[email protected] |
Note: This message is automatically posted and updated by the Manifest GitHub Action.
@nashif and @carlescufi this PR is adding a new subsystem and @mbolivar-nordic has requested that I CC you.
@nashif and @carlescufi this PR is adding a new subsystem and @mbolivar-nordic has requested that I CC you.
@sambhurst sorry if I was unclear -- when I wrote:
(cc @nashif @carlescufi )
that was actually me cc'ing them, not asking you to CC them
I don't see any documentation for the usbc_vbus_api group in Sphinx. Am I missing it? Please dismiss my review if so. Otherwise, please add it.
@sambhurst are you going to address this comment? I see a new push since I asked this question, but it is still unaddressed.
I don't see any documentation for the usbc_vbus_api group in Sphinx. Am I missing it? Please dismiss my review if so. Otherwise, please add it.
@sambhurst are you going to address this comment? I see a new push since I asked this question, but it is still unaddressed.
@mbolivar-nordic Yes I added the documentation in my last push.
@galak I was not aware of the Linux USB-C bindings but it seems I'm duplicating the Sink and VBUS portion.
@galak and @mbolivar-nordic are there any other changes you'd like me to make. Thanks
@galak I was not aware of the Linux USB-C bindings but it seems I'm duplicating the Sink and VBUS portion.
Can you move to using the linux bindings as this is one of our design goals
@galak I was not aware of the Linux USB-C bindings but it seems I'm duplicating the Sink and VBUS portion.
Can you move to using the linux bindings as this is one of our design goals
@galak I've included the linux bindings for the USB-C Connector.
Is there any expectation of the USBC APIs working with userspace?
@galak Currently there are no expectations for the USBC APIs to work with userspace, although this feature could be added at a later date.
Any plans to update MAINTAINERS.yml for this?
Who will be maintaining this code?
@galak I have added myself as the maintainer of the code and I'm sure there will be many contributors.
@carlescufi should the PR update doc/develop/api/overview.rst?
@galak I've updated the overview.rst file.
@galak Currently there are no expectations for the USBC APIs to work with userspace, although this feature could be added at a later date.
So my comment earlier about adding __subsystem was wrong, please remove that since there is no expectation for userspace support.
So my comment earlier about adding __subsystem was wrong, please remove that since there is no expectation for userspace support.
@galak I've removed __subsystem
General: think about places that using
usb-cmight be a little easier to read thanusbc(dir names, file names, etc).
@galak I went through the PR and updated the names from usbc to usb_c