zephyr
zephyr copied to clipboard
zephyrproject-rtos
Improve the eSPI emulators
These commits refactor the eSPI emulators and implement the missing logic for the LPC-over-eSPI requests and also the built-in 8042 keyboard controller.
LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code
LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code
I will fix this code, since some checks failed, and then I will paste here a link to the tests using these emulators.
LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code
There is code that uses the emulators: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3613913 Files that implement the tests logic are in path: zephyr/test/drivers/src/
LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code
I think the only examples are the files touched by these commits.
I have refactored the PR and removed some unused code. I hope that I haven't missed any change suggestions.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yperess can you re-review this? (you have a pending blocking comment)
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.
Nothing here jumps out at me as being bad but I'm not terribly involved in espi.
Are @albertofloyd, @VenkatKotakonda, and @jvasanth1 able to re-review?
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.