sdk-ng icon indicating copy to clipboard operation
sdk-ng copied to clipboard

xtensa: remove unused intel_bdw and intel_byt

Open dcpleung opened this issue 1 year ago • 6 comments

Both intel_bdw and intel_byt are not being used in upstream Zephyr project. So there is no need to build them.

Signed-off-by: Daniel Leung [email protected]

dcpleung avatar Oct 25 '22 16:10 dcpleung

Quick grep on Zephyr main repo says that these are never used.

dcpleung avatar Oct 25 '22 16:10 dcpleung

cc @marc-hb

stephanosio avatar Oct 25 '22 17:10 stephanosio

Hm... Are there other GitHub workflow files I need to change? CI is still building the removed toolchains even though I removed them from .github/workflows/ci.yml.

dcpleung avatar Oct 25 '22 18:10 dcpleung

Hm... Are there other GitHub workflow files I need to change? CI is still building the removed toolchains even though I removed them from .github/workflows/ci.yml.

Pull request CI uses the workflow from the base branch due to various security reasons. It will work as intended once merged.

stephanosio avatar Oct 25 '22 18:10 stephanosio

@dcpleung was thinking about this the other day and was going to ask if we still needed them :).

galak avatar Oct 26 '22 13:10 galak

Not needed. Can be removed.

lgirdwood avatar Oct 26 '22 14:10 lgirdwood

@dcpleung There are merge conflicts. Could you rebase?

stephanosio avatar Nov 23 '22 08:11 stephanosio

@dcpleung looks like the GH action will need an update too in order to remove the check for the removed platforms.

lgirdwood avatar Nov 25 '22 14:11 lgirdwood

Rebased. Picolib has GitHub actions on BDW and BYT so those need to be removed too.

dcpleung avatar Nov 28 '22 17:11 dcpleung

Here is the link to the picolib change: https://github.com/zephyrproject-rtos/picolibc/pull/2

dcpleung avatar Nov 28 '22 17:11 dcpleung

Picolibc PR: https://github.com/picolibc/picolibc/pull/391

dcpleung avatar Nov 28 '22 18:11 dcpleung