opengfx2 icon indicating copy to clipboard operation
opengfx2 copied to clipboard

Replace bash with make to improve build times, and improve reliability.

Open YellowOnion opened this issue 1 year ago • 1 comments

Your build system makes it very hard to run multiple jobs on multiple cores.

or skip parts of the build process that have already run.

Make allows you to trivially define a dependency graph, and it will run tasks in parallel using the '--jobs=' parameter, checking to see if the output files exist to skip jobs.

https://linuxhint.com/compiling-code-using-make/

Using a recursive make pattern should be similar to what you're doing here and maintain parallelism

https://stackoverflow.com/questions/1681006/parallelization-of-recursive-jobs-in-gnu-make

Your build system has some other weird things like calling bash instead of using shebangs, and the python scripts don't have the correct file system permissions so you can't actually run them on Linux them despite having shebangs, appending $PWD to $PATH instead of using ./script.py, I assume this isn't actually being built Linux/Unix, and instead on something like WSL due to this.

Would you accept a PR replacing bash with make?

YellowOnion avatar Jul 10 '23 14:07 YellowOnion