Justin Bennett

Results 95 comments of Justin Bennett

You'll likely need #26 to get the example to work. I did at least.

Thanks for reporting! I'm looking into this and will report back when I have updates or a fix. 👍

Hey @marcianosr sorry about the long delay, it's been a busy few months. Could you possibly provide a reproduction that shows this issue? I've got a minimal codesandbox example [here](https://codesandbox.io/s/fresnel-orientation-test-7ho2t?file=/src/index.js)...

Thanks for the sleuthing! I'll dig back into it and see what I come up with.

I don't think we can commit anyone to fully taking on the work at the moment, but we're definitely open for pull requests and would be happy to collab on...

Hey @karol-majewski I just merged the typescript 4.0 upgrade. I'd be happy to pair w/ you on this sometime. Maybe even could get some of the Artsy crew in on...

Saturday would work for me! @karol-majewski how about you?

Note for documentation updates: - Add requirement that there's always a breakpoint of size 0 (maybe add a warning or error) - Add documentation around negation of all other rules...

@smithki it would be a problem, yeah. The challenge here is during SSR we don't know which breakpoints we're rendering for so we render _all_ the breakpoints and use media...

It's notable that anyone taking this step will also need to ensure their index settings are correct. You can see the settings the scraper adds [here](https://github.com/meilisearch/docs-scraper/blob/776bdb3dd1bce490c44dfa53f99ae8d9e57fcf43/scraper/src/meilisearch_helper.py#L48-L99).