zephir icon indicating copy to clipboard operation
zephir copied to clipboard

#2321 - Fix private callback visibility

Open Jeckerson opened this issue 2 years ago • 3 comments

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • [x] I have checked that another pull request for this purpose does not exist
  • [x] I wrote some tests for this PR
  • [ ] I updated the CHANGELOG

Small description of change:

Thanks

Jeckerson avatar Nov 12 '21 23:11 Jeckerson

Codecov Report

Merging #2325 (a5a6b18) into development (fd6e5f1) will decrease coverage by 0.04%. The diff coverage is 18.42%.

@@               Coverage Diff                @@
##             development   #2325      +/-   ##
================================================
- Coverage           7.18%   7.13%   -0.05%     
+ Complexity          8639    8612      -27     
================================================
  Files                343     344       +1     
  Lines              21977   21939      -38     
================================================
- Hits                1578    1566      -12     
+ Misses             20399   20373      -26     

codecov[bot] avatar Nov 13 '21 23:11 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Dec 28 '21 16:12 sonarcloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Mar 26 '22 20:03 sonarcloud[bot]