react-native-portal icon indicating copy to clipboard operation
react-native-portal copied to clipboard

React peerDependency

Open pwlmaciejewski opened this issue 5 years ago • 1 comments

Current state

In package.json, react is defined as a dependency.

Expected

It should define react as peer dependency.

Workaround

yarn resolutions

pwlmaciejewski avatar Aug 22 '19 08:08 pwlmaciejewski

It creates a lot of issues: basically, when you add react-native-portal, you automatically add the latest version of React to your bundle, which is probably a different version from the one you are currently using. You then end up with two different versions of React in your bundle

WaldoJeffers avatar Nov 05 '19 14:11 WaldoJeffers