foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Upgrade not compatible with rector 2

Open nesl247 opened this issue 11 months ago • 2 comments

Rector 2.0 seems to have removed SetListInterface, so it is not possible to run the set list without downgrading.

The rules also don't work unfortunately:

         "System error: "The `Rector\Rector\AbstractScopeAwareRector` is removed, use `Rector\Rector\AbstractRector`
         instead, see upgrading guide https://github.com/rectorphp/rector-src/blob/main/UPGRADING.md#1-abstractscopeawarerector-is-removed-use-abstractrector-instead"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 20```

nesl247 avatar Jan 08 '25 22:01 nesl247

Hi @nesl247

thanks for reporting. Yeah, I was expecting problems like this with Rector 2.

I don't know when I'll have time to work on this. Don't hesitate to provide a PR :)

nikophil avatar Jan 09 '25 07:01 nikophil

I ended up doing it manually, so I don't have a need for it anymore unfortunately. If I find some time I'll try to tackle it, but it will probably be a while before then.

nesl247 avatar Jan 10 '25 21:01 nesl247

this has been fixed in #913

nikophil avatar Jul 06 '25 17:07 nikophil