foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Published 20 hours ago • verified publisher icon zenstruck

use phpunit attributes

Open jrushlow opened this issue 1 year ago • 1 comments

Starting in PHPUnit 11 - the use of metadata in doc-comments is hard deprecated. Results in tests passing as expected but PHPUnit deprecation warnings everywhere...

jrushlow avatar Feb 17 '24 22:02 jrushlow

Not sure if ya'll use any sort of @legacy comments like we do in MakerBundle. If so, let me know and I'll add them to the doc-comments. E.g. @after - @legacy - can be removed when PHPUnit <10 support is dropped.

jrushlow avatar Feb 17 '24 22:02 jrushlow

Hi @jrushlow

sorry to have been quite on this lately.

Because we only use phpunit ^9.5, I don't think we'll need any @group legacy for now?

could rebase your PR, please?

nikophil avatar Mar 20 '24 07:03 nikophil

@nikophil rebase done

don't think the ci failure is related.. looks like a php-cs-fixer type of problem

jrushlow avatar Mar 20 '24 08:03 jrushlow

absolutely, I'll fix this today

nikophil avatar Mar 20 '24 08:03 nikophil

thanks @jrushlow

nikophil avatar Mar 20 '24 13:03 nikophil