foundry icon indicating copy to clipboard operation
foundry copied to clipboard

feat: support `doctrine/orm` 3

Open kbond opened this issue 1 year ago • 4 comments
trafficstars

TODO:

  • [ ] sqlite changes. We don't currently test but there are some breaking changes when using ResetDatabase with sqlite

kbond avatar Feb 05 '24 16:02 kbond

won't it be a PITA to maintain tests for both versions?

nikophil avatar Feb 05 '24 17:02 nikophil

Possibly, but if we bump the min orm to latest 2.x, perhaps it won't be a problem?

kbond avatar Feb 05 '24 17:02 kbond

I think some of the work done in https://github.com/symfony/maker-bundle/pull/1439 could help us here.

kbond avatar Feb 07 '24 19:02 kbond

MakeTestRunner::configureDatabase() has the logic we needed to get sqlite to work with the new orm - https://github.com/symfony/maker-bundle/blob/d9574302ee67c23ae5c803556f2b779c3b0b94a2/src/Test/MakerTestRunner.php#L156

jrushlow avatar Feb 16 '24 14:02 jrushlow

closed in favor of https://github.com/zenstruck/foundry/pull/569

nikophil avatar Mar 20 '24 07:03 nikophil