foundry
foundry copied to clipboard
Deprecate `addState()` in favor of `withAttributes()`
What is the semantic difference between using Factory::addState() and Factory::withAttributes()?
The former seems to simply dispatch to the latter.
Is there more intention behind it and should I be careful when I use which?
No difference, it's really just a way to be more explicit when writing state methods. I think I'd be ok to deprecate addState - wdyt @nikophil?
yes, I'm fine with it, moreover, in the version with "split factories", addState() and withAttributes() are in the same class
Fixed in #493.