zenstack icon indicating copy to clipboard operation
zenstack copied to clipboard

[feature request]: implement shorthand for `@readonly` as `z.literal()`

Open sakgoyal opened this issue 1 year ago • 4 comments

sakgoyal avatar Apr 02 '24 03:04 sakgoyal

[!IMPORTANT]

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Apr 02 '24 03:04 coderabbitai[bot]

Hi @sakgoyal , thanks for the PR again 😄.

I want to be conservative with introducing new attributes because each of them adds some cognitive cost to the users. May I keep this PR on hold until we get a few more similar ask for the feature? If your main need here is zod schema here, maybe you can also use zod API to extend the generated schemas?

ymc9 avatar Apr 02 '24 20:04 ymc9

that is why I kept it as a draft. I wanted feedback before continuing. I will gladly wait since it is not urgent for me.

sakgoyal avatar Apr 02 '24 21:04 sakgoyal

that is why I kept it as a draft. I wanted feedback before continuing. I will gladly wait since it is not urgent for me.

Got it. Thanks for understanding!

ymc9 avatar Apr 03 '24 22:04 ymc9

Closing for now since there's no plan to merge in the near future

ymc9 avatar Jul 07 '24 15:07 ymc9