Dmitry Zenovich comments

Results 45 comments of


                                            Dmitry Zenovich

ethereum,ethclient,eth/filters: marshal/unmarshal ethereum.FilterQuery struct to/from JSON correctly

No problem, @fjl. I'll rework that. By the way, there is a question. The Ethereum Wiki (https://eth.wiki/json-rpc/API#parameters-45) says that if 'fromBlock' is missing it is treated as 'latest' while ethclient.toFilterArg()...

ethereum,ethclient,eth/filters: marshal/unmarshal ethereum.FilterQuery struct to/from JSON correctly

> > By the way, there is a question. The Ethereum Wiki (https://eth.wiki/json-rpc/API#parameters-45) says that if 'fromBlock' is missing it is treated as 'latest' while ethclient.toFilterArg() treats FromBlock==nil as 0x0...

ethereum,ethclient,eth/filters: marshal/unmarshal ethereum.FilterQuery struct to/from JSON correctly

@fjl, can we merge please?

accounts/abi: Add support for fixed-point types + add more checks on ABI function parameter types

Can someone review this one please?

accounts/abi: Add support for fixed-point types + add more checks on ABI function parameter types

@holiman, can we merge please?

Introduce a new command-line parameter for "generate spec" allowing to set "x-nullable: true" by default for each Go field having a pointer type and not having JSON 'omitempty' option set

Thanks! 👍🏻

Preserve descriptions and tags of Go fields containing embedded structures

> Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments. > > Comments suppressed due to low confidence (1) > **codescan/schema.go:1067** > >...

encoding/json: custom type marshaling doesn't work for map values

> This is a known problem. It is related to but not quite identical to #33993 and #22967. > > Fundamentally, the issue is that the "encoding/json" package has an...

encoding/json: custom type marshaling doesn't work for map values

It's a really sad story. At the same time, it looks like [Go 1 and the Future of Go Programs: Expectations](https://go.dev/doc/go1compat#expectations) explicitly allow breaking code that relies on unspecified behavior.

encoding/json: custom type marshaling doesn't work for map values

@ianlancetaylor, As a follow-up to our recent conversation in #68919, I would like to ask you to take a look at the change I've made to fix the issue: https://go.dev/cl/606495....