hyperrogue icon indicating copy to clipboard operation
hyperrogue copied to clipboard

Move land check functions to the top

Open emmiegit opened this issue 3 years ago • 2 comments

Minor PR that is a complement to https://github.com/zenorogue/hyperrogue/pull/212.

It standardizes the function such that land check functions appear at the top rather than scattered throughout.

emmiegit avatar Jul 10 '21 23:07 emmiegit

Could these symmetric checks (crossroads/elemental) be moved from incompatible1() to incompatible()?

jruderman avatar Jul 11 '21 00:07 jruderman

I see, incompatible() is the wrapper. You're suggesting moving it because the symmetry means additional checks are being performed that are not necessary.

emmiegit avatar Jul 11 '21 03:07 emmiegit