react-quill icon indicating copy to clipboard operation
react-quill copied to clipboard

Fixes findDOMNode errors for react 18

Open wesrog opened this issue 1 year ago • 11 comments

wesrog avatar May 31 '24 16:05 wesrog

You can use this meanwhile, added your fix here: npm i react-quill@https://github.com/lassespilling/react-quill-2024/tree/package

lassespilling avatar Jun 18 '24 09:06 lassespilling

You can use this meanwhile, added your fix here: npm i react-quill@https://github.com/lassespilling/react-quill-2024/tree/package

Thanks. It works

M-Farmaha avatar Jun 19 '24 09:06 M-Farmaha

@lassespilling Thanks for the repo, do you mind publishing a package with your fix? with yarn v1 and I can't use your changes

hamidrezahanafi avatar Jul 18 '24 15:07 hamidrezahanafi

@lassespilling Thanks for the repo!!

I noticed this library uses 'DOMNodeInserted' events, which are deprecated. Any plans to switch to MutationObserver? Happy to provide more info if needed.

Thanks for maintaining this project!

sunjae-kim avatar Jul 23 '24 04:07 sunjae-kim

@lassespilling Thanks for the repo!!

I noticed this library uses 'DOMNodeInserted' events, which are deprecated. Any plans to switch to MutationObserver? Happy to provide more info if needed.

Thanks for maintaining this project!

This would be incredibly helpful! I am currently running into this issue with my use of this repository.

I have not 100% identified the issue within my codebase but I believe the following error in conjunction with custom logic built on top of my React-Quill editor causing content to be wiped from my React-Quill editor when users copy and paste content into the editor.

For context, here is the full console warning for any maintainers 🙏

Deprecation] Listener added for a 'DOMNodeInserted' mutation event. This event type is deprecated, and will be removed from this browser very soon. Usage of this event listener will cause performance issues today, and represents a large risk of future site breakage. Consider using MutationObserver instead. See https://chromestatus.com/feature/5083947249172480 for more information.

Defconn4 avatar Aug 08 '24 20:08 Defconn4

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

hamidrezahanafi avatar Aug 08 '24 20:08 hamidrezahanafi

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

This is also not working... Im getting the same error [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired. See https://chromestatus.com/feature/5083947249172480 for more information.

DamithaPerera avatar Aug 29 '24 14:08 DamithaPerera

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

This is awesome! Thanks so much ❤️

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

This is also not working... Im getting the same error [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired. See https://chromestatus.com/feature/5083947249172480 for more information.

Hm, I’m not seeing this. Looking through the repo, DOMNodeInserted is only used in a MutationObserver polyfill, which is only used in tests. So I'm wondering if maybe your NPM dependencies were cached? You shouldn’t be seeing this on react-quill-new.

joshwcomeau avatar Jan 06 '25 17:01 joshwcomeau

When I install this, will it overwrite the currently installed react-quill? Or will I have to specify the imports?

JedPapa avatar Feb 17 '25 17:02 JedPapa

When I install this, will it overwrite the currently installed react-quill? Or will I have to specify the imports?

I think no... it will not overwrite. just run npm install react-quill-new --save

DamithaPerera avatar Feb 18 '25 09:02 DamithaPerera