react-quill icon indicating copy to clipboard operation
react-quill copied to clipboard

Improved Accessibility

Open jamesmart77 opened this issue 4 years ago • 5 comments

Hello,

This library is fantastic and our team thoroughly enjoys using it! As we are making efforts to move toward full accessibility support in our apps, we ran a "lighthouse" report in Chrome and found several alerts around buttons not having "accessible names" from the library.

image

Above is a screenshot of the report for reference.

We are using the version 1.3.5. Thanks for your creation and support of such a friendly library!

jamesmart77 avatar Oct 12 '20 14:10 jamesmart77

I would also suggest to add role="textbox to the editable container

<div role="textbox" contenteditable="true"></div>

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/textbox_role

infernalmaster avatar Oct 12 '20 14:10 infernalmaster

Can you raise this upstream in Quill? We don't actually control very much of the DOM the editor outputs.

alexkrolick avatar Oct 13 '20 19:10 alexkrolick

This seems like it would be easy to add to the Quill editor. I am requesting to be a collaborator on that project in order to push up these changes to the repo. What would the process be to bring the changes downstream into this repo once approved?

clairefields15 avatar Jun 07 '22 22:06 clairefields15

We'd just need to update the Quill dependency range once merged upstream

alexkrolick avatar Jun 08 '22 19:06 alexkrolick

Any updates on this? It would significantly improve the ability to make accessible tests.

esetnik avatar Aug 16 '23 20:08 esetnik