Kevin O'Gorman

Results 291 comments of Kevin O'Gorman

Moving to 2.6.0, haven't touched this in time for 2.5.0.

(Not a CI issue as these tests are hw-specific)

(Rebased as the auto-rebase in CI was breaking tests due to pageslayout changes introduced elsewhere.)

@cfm that's valid, it is a bit :thinking: that we can make a change like this with no test suite impact. Will add later.

In lieu of adding tests, updated existing ones that check the relevant behavior - feel free to take a look @cfm

TBH I might not aim to have this in scope for 2.5.0. I think we need to do a bit more around key/account cleanup (especially for unused pending accounts) before...

extra points ftw - how did it break?

Still a good idea, research required before proceeding.

Noting that schema changes are easier now, so we can add a new table for backup codes as necessary. Some small amount of UX + Security research tbd before proceeding....

We missed the chance to do this for both Xenial and Focal, will try to catch it next time :)