zenml icon indicating copy to clipboard operation
zenml copied to clipboard

[FEATURE]: Handle over 100 secrets when using the `AWSSecretsManager`

Open strickvl opened this issue 2 years ago • 0 comments

Contact Details [Optional]

[email protected]

Describe the feature you'd like

The get_all_secret_keys method (found at src/zenml/integrations/aws/secrets_managers/aws_secrets_manager.py) currently has an inbuilt limit whereby it can only access 100 secrets stored in the AWSSecretsManager. This has to do with the fact that the API effectively paginates the results. We currently hard-code the max number of results in the method, but ideally:

  • we would be able to handle an arbitrary number of secrets (i.e. greater than 100) stored on AWS
  • we would no longer hard-code the magic 100 value

Is your feature request related to a problem?

No response

How do you solve your current problem with the current status-quo of ZenML?

Currently we limit the number of secrets that you can query from AWS to 100.

Any other comments?

This is related to #ENG-721 and #ENG-720.

strickvl avatar May 23 '22 12:05 strickvl