zenml icon indicating copy to clipboard operation
zenml copied to clipboard

Fix unicode decode errors in k8s pod logs read operation

Open wjayesh opened this issue 8 months ago • 1 comments

Describe changes

I fixed the unicode errors that happen when the logs have characters not from utf-8. In this PR,

  • we configure the read_namespaced_pod_log to return raw responses instead of decoded ones
  • decode the raw response to string replacing any error chars with a replacement char.

Pre-requisites

Please ensure you have done the following:

  • [ ] I have read the CONTRIBUTING.md document.
  • [ ] If my change requires a change to docs, I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • [ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other (add details above)

wjayesh avatar Jun 26 '24 04:06 wjayesh