zenml icon indicating copy to clipboard operation
zenml copied to clipboard

Integrate core azureml orchestrator logic

Open bhatt-priyadutt opened this issue 2 years ago β€’ 3 comments

Describe changes

Creating PR to see the changes

Pre-requisites

Please ensure you have done the following:

  • [X] I have read the CONTRIBUTING.md document.
  • [ ] If my change requires a change to docs, I have updated the documentation accordingly.
  • [ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
  • [ ] I have added tests to cover my changes.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other (add details above)

bhatt-priyadutt avatar Jun 30 '23 13:06 bhatt-priyadutt

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Microsoft Azure Storage Account Key 3b27880a45891f19e436ab81c13d57daba99881e examples/azure_ml_orchestrator_flavor/orchestrator/azure_ml_pipelines_orchestrator.py View secret
- Microsoft Azure Storage Account Key 70f1ea0ce540c83ee6377e457303f835d85303c7 examples/azure_ml_orchestrator_flavor/orchestrator/azure_ml_pipelines_orchestrator.py View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Aug 15 '23 16:08 gitguardian[bot]

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: avishniakov
:white_check_mark: strickvl
:white_check_mark: bhatt-priyadutt
:white_check_mark: htahir1
:white_check_mark: stefannica
:x: Felix Altenberger


Felix Altenberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 30 '24 14:01 CLAassistant

Closing this in favor of https://github.com/zenml-io/zenml/pull/1743 (which I believe supersedes it)

strickvl avatar Feb 28 '24 13:02 strickvl