Ian Denhardt

Results 574 comments of Ian Denhardt

This is still valid. IIRC `network_create_simple` existed at the time as well, but it's a band-aid over an underlying ugly api. #455 is orthoginal to this.

Thought: can we query pytest-xdist to get some kind of worker-id? Python's `ConfigParser` supports variable interpolation; depending on what pytest-xdist gives us to work with we could expose the worker-id...

Unless there's a use case for toggling jumbo frames during normal HIL operation, I'd prefer to leave it out of the API. If it's something we're just doing on-set up,...

I think except for testing physical connectivity we're good. That's a big task on it's own, though it would be nice.

Would be good to accumulate a list of cases that need dealing with. The one you mentioned: * `project_detach_node` raises `BlockedError` if any resource is still attached to the node,...

It's not obvious to me that it makes sense to have these two use cases have a shared ancestor. Can you think of a case where we'd want to handle...

Right, but the server sends them to the client as JSON, where the type is just a string, and it doesn't include information about what the superclasses are.

Nothing jumps to mind; I think the proposed solution still makes sense. The two suggestions should probably be separate prs, just to keep them small and self contained.

hil-admin is local-only; it doesn't use the API; the `hil` command line tool is the right spot for API wrappers.