Ian Denhardt

Results 428 comments of Ian Denhardt

Looks like on my system it was picking up the system capnp; will have to do a bit more fiddling to get it to use the in-tree one. Marking this...

See my comment above: yes, but that was not my intent, which is why this is marked as a draft.

Alright, I've gotten it to use the in-tree capnp now (and only build capnp.node once). This required changes in node-capnp's repo, so https://github.com/capnproto/node-capnp/pull/65 will have to be merged for this...

Hm, normally this failing really isn't fatal, since if you're doing a system-wide install it starts up as root and can use the privileged sandbox, so under normal usage `install.sh`...

@troyjfarrell, made a couple comments in-line. Didn't read the full code, I assumed you just moved stuff and added annotations, so only really looked at the use of types. tsc...

@troyjfarrell, Re: the concat error I assume you're talking about: ```javascript Meteor.call.apply(Meteor, ["newApiToken"].concat(params, callback)); ``` I don't really understand why that's not just: ```javascript Meteor.call("newApiToken", params, callback) ``` ...which might...

fwiw, wake locks don't require user input to grant, but do trigger a notification with the ability to revoke. Previous discussion: https://github.com/sandstorm-io/sandstorm/pull/2922#issuecomment-561365864 I think we came to the conclusion that...

Ok, so soonish I'll swap out the cancel buttons for a disable toggle, and at some point we'll add the notification as well. But that still leaves this issue. I...

To try to identify a couple specific problems, to make this a bit closer to actionable: - There's not really much context given at the top of the page; most...

Here you go: ![Screen Shot 2020-04-27 at 11 53 32](https://user-images.githubusercontent.com/883774/80392994-de4b7c80-887d-11ea-824b-623fcfdbab27.png)