zengm icon indicating copy to clipboard operation
zengm copied to clipboard

Trade filter

Open mchvn opened this issue 5 years ago • 3 comments

mchvn avatar Feb 09 '21 01:02 mchvn

@dumbmatter So if I wanted to continue working on this PR how would I do that. Would I need to create a new pull request? Or somehow get permission from @mchvn to use what he has currently worked on and work off that? Not sure how to move forward.

maxkarnold avatar Jul 04 '22 18:07 maxkarnold

@dumbmatter So if I wanted to continue working on this PR how would I do that. Would I need to create a new pull request? Or somehow get permission from @mchvn to use what he has currently worked on and work off that? Not sure how to move forward.

I'm not sure... a lot of things have changed since this PR was made, so it might take some work to merge the latest commits. Then you'd need to address the issues with it. Probably in a new PR based on this.

Or, it might be easier to start from scratch. Maybe influenced a bit by this code.

dumbmatter avatar Jul 04 '22 21:07 dumbmatter

@dumbmatter So if I wanted to continue working on this PR how would I do that. Would I need to create a new pull request? Or somehow get permission from @mchvn to use what he has currently worked on and work off that? Not sure how to move forward.

I'm not sure... a lot of things have changed since this PR was made, so it might take some work to merge the latest commits. Then you'd need to address the issues with it. Probably in a new PR based on this.

Or, it might be easier to start from scratch. Maybe influenced a bit by this code.

Sounds good, I'll keep this PR as a reference and take a look at where we can use this code.

maxkarnold avatar Jul 05 '22 01:07 maxkarnold